-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-39134: [Java] Create module info compiler plugin #39135
Conversation
|
a26e026
to
1e1c045
Compare
</dependencies> | ||
|
||
<build> | ||
<pluginManagement><!-- lock down plugins versions to avoid using Maven defaults (may be moved to parent pom) --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we want to avoid the defaults/are these inconsistent with the global config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was generated by the maven plugin archetype I used.
1e1c045
to
0aa8605
Compare
Note that some configuration from the arrow root POM is copied to the maven plugins module because it cannot be inherited without creating a cyclic depdendency.
Reports a used dependency as unused only on Windows 2022 CI runs
It is not correctly getting skipped.
This won't build with the JDK 8 target
Newer versions of the checkstyle plugin do support module-info.java files but require rewriting the checkstyle rules file.
Add a test goal to the module-info-compiler plugin. Rename goals to be consistent with maven-compiler-plugin
0aa8605
to
dea90f9
Compare
@github-actions crossbow submit java |
Revision: dea90f9 Submitted crossbow builds: ursacomputing/crossbow @ actions-0fe7a83d3b |
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit d0e74d7. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change Create and integrate a maven plugin for compiling module-info.java files without using maven-compiler-plugin and release 9+. This is necessary for supporting Java 8 unsafe code, which has different than unsafe code in JDK 9. ### What changes are included in this PR? - Add the module-info-compiler-maven-plugin and utilize it in the codebase. - Exclude module-info.java files from maven-compiler-plugin. ### Are these changes tested? Yes, they generate valid module-info.class files in JARs and test JARs. ### Are there any user-facing changes? No * Closes: apache#39134 Authored-by: James Duong <[email protected]> Signed-off-by: David Li <[email protected]>
@jduo It seems that this broke our documentation CI job. Could you check it? https://github.com/apache/arrow/actions/runs/7182308293/job/19558525786#step:7:13088
|
### Rationale for this change Create and integrate a maven plugin for compiling module-info.java files without using maven-compiler-plugin and release 9+. This is necessary for supporting Java 8 unsafe code, which has different than unsafe code in JDK 9. ### What changes are included in this PR? - Add the module-info-compiler-maven-plugin and utilize it in the codebase. - Exclude module-info.java files from maven-compiler-plugin. ### Are these changes tested? Yes, they generate valid module-info.class files in JARs and test JARs. ### Are there any user-facing changes? No * Closes: apache#39134 Authored-by: James Duong <[email protected]> Signed-off-by: David Li <[email protected]>
### Rationale for this change Create and integrate a maven plugin for compiling module-info.java files without using maven-compiler-plugin and release 9+. This is necessary for supporting Java 8 unsafe code, which has different than unsafe code in JDK 9. ### What changes are included in this PR? - Add the module-info-compiler-maven-plugin and utilize it in the codebase. - Exclude module-info.java files from maven-compiler-plugin. ### Are these changes tested? Yes, they generate valid module-info.class files in JARs and test JARs. ### Are there any user-facing changes? No * Closes: apache#39134 Authored-by: James Duong <[email protected]> Signed-off-by: David Li <[email protected]>
Rationale for this change
Create and integrate a maven plugin for compiling module-info.java files without using maven-compiler-plugin
and release 9+. This is necessary for supporting Java 8 unsafe code, which has different than unsafe code
in JDK 9.
What changes are included in this PR?
Are these changes tested?
Yes, they generate valid module-info.class files in JARs and test JARs.
Are there any user-facing changes?
No