-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-38997: [Java] Modularize format and vector #38995
GH-38997: [Java] Modularize format and vector #38995
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
4947db9
to
54446ec
Compare
|
0b49cfa
to
83bab66
Compare
This is on my backlog - I'm hoping to give this a review this week |
Thanks for the review @lidavidm . This shouldn't go in yet until we're ready to bite the bullet on modularizing memory-core + making the command-line change though (or we figure out how to avoid the command-line change). I'm changing this back to draft for the time being. |
83bab66
to
0342cb3
Compare
47030a0
to
f39d07b
Compare
b99f597
to
ccd5ffc
Compare
ccd5ffc
to
038549a
Compare
038549a
to
d0c891b
Compare
Note that this one didn't require doc changes. |
cedbd00
to
ae7bacb
Compare
@davisusanibar can you help take a look at the nullness annotation issues here? |
ae7bacb
to
1e7d5e9
Compare
I fixed a null annotation issue with CountingAllocationListener in the parent patch (#39011). |
Ah whoops, I thought I was looking at that one. |
I think this just needs to be rebased? |
Do not add tests in org.apache.arrow.util because that is an exported package for arrow-memory-core and causes module conflicts
Having an implicit dependency from arrow-memory-core does not put immutables on the module-path when running tests and causes module issues.
Export public package for arrow-vector module. Allow jackson to use arrow-vector pojo classes reflectively for serialization.
Needed because Vector classes use MemoryUtil.UNSAFE.
Also don't depend on jdk.unsupported
Needed because it uses MemoryUtil.UNSAFE
1e7d5e9
to
94b9c20
Compare
Yes, this is rebased now @lidavidm |
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 1a622ec. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change This PR depends on apache#39011 . Make arrow-vector and arrow-format JPMS modules for improved compatibility with newer JDKs and tools that require modules. ### What changes are included in this PR? * add module-info.java files for vector and format. ### Are these changes tested? Yes, these modules are run as JPMS modules in JDK9+ unit tests. ### Are there any user-facing changes? Yes, some test classes have moved and users can now run these as JPMS modules. * Closes: apache#38997
### Rationale for this change This PR depends on apache#39011 . Make arrow-vector and arrow-format JPMS modules for improved compatibility with newer JDKs and tools that require modules. ### What changes are included in this PR? * add module-info.java files for vector and format. ### Are these changes tested? Yes, these modules are run as JPMS modules in JDK9+ unit tests. ### Are there any user-facing changes? Yes, some test classes have moved and users can now run these as JPMS modules. * Closes: apache#38997
### Rationale for this change This PR depends on apache#39011 . Make arrow-vector and arrow-format JPMS modules for improved compatibility with newer JDKs and tools that require modules. ### What changes are included in this PR? * add module-info.java files for vector and format. ### Are these changes tested? Yes, these modules are run as JPMS modules in JDK9+ unit tests. ### Are there any user-facing changes? Yes, some test classes have moved and users can now run these as JPMS modules. * Closes: apache#38997
### Rationale for this change This PR depends on apache#39011 . Make arrow-vector and arrow-format JPMS modules for improved compatibility with newer JDKs and tools that require modules. ### What changes are included in this PR? * add module-info.java files for vector and format. ### Are these changes tested? Yes, these modules are run as JPMS modules in JDK9+ unit tests. ### Are there any user-facing changes? Yes, some test classes have moved and users can now run these as JPMS modules. * Closes: apache#38997
Rationale for this change
This PR depends on #39011 .
Make arrow-vector and arrow-format JPMS modules for improved compatibility with newer JDKs
and tools that require modules.
What changes are included in this PR?
Are these changes tested?
Yes, these modules are run as JPMS modules in JDK9+ unit tests.
Are there any user-facing changes?
Yes, some test classes have moved and users can now run these as JPMS modules.