GH-37884: [Swift] Allow reading of unaligned FlatBuffers buffers #38635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
abandy
force-pushed
the
37884
branch
2 times, most recently
from
ea6ee75 to
4114f5a
Compare
|
@kou Please review when you get a chance. |
kou
approved these changes
Dec 5, 2023
| @@ -32,7 +32,7 @@ let package = Package( | |||
| targets: ["Arrow"]), | |||
| ], | |||
| dependencies: [ | |||
| .package(url: "https://github.com/google/flatbuffers.git", from: "23.3.3") | |||
| .package(url: "https://github.com/google/flatbuffers.git", branch: "master") | |||
There was a problem hiding this comment.
Could you add a comment why we need to use master for now and when we can specify a tag again?
github-actions
bot
added
awaiting merge
|
@kou Please merge when you get a chance. Thank you! |
kou
changed the title
kou
changed the title
|
Done! |
|
Nice to hear about that!!! |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit ad63158. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
mapleFU
pushed a commit
to mapleFU/arrow
that referenced
this pull request
Dec 13, 2023
apache#38635) The PR enables the swift readers to read from unaligned buffers (fix for issue: 37884) Enabling unaligned buffers incurs a performance penalty so the developer will need to consider this when enabling this feature. It is not currently possible to recover from a buffer unaligned error as this error is a fatalError so trying aligned and then falling back to unaligned is not an option. Also, FlatBuffers has a verifier that should be able to catch this error but currently it seems to fail on both aligned and unaligned buffers (I tried verifying the example python server get return value but verification fails even though the buffers are able to be read successfully) * Closes: apache#37884 Authored-by: Alva Bandy <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
clayburn
pushed a commit
to clayburn/arrow
that referenced
this pull request
Jan 23, 2024
apache#38635) The PR enables the swift readers to read from unaligned buffers (fix for issue: 37884) Enabling unaligned buffers incurs a performance penalty so the developer will need to consider this when enabling this feature. It is not currently possible to recover from a buffer unaligned error as this error is a fatalError so trying aligned and then falling back to unaligned is not an option. Also, FlatBuffers has a verifier that should be able to catch this error but currently it seems to fail on both aligned and unaligned buffers (I tried verifying the example python server get return value but verification fails even though the buffers are able to be read successfully) * Closes: apache#37884 Authored-by: Alva Bandy <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
apache#38635) The PR enables the swift readers to read from unaligned buffers (fix for issue: 37884) Enabling unaligned buffers incurs a performance penalty so the developer will need to consider this when enabling this feature. It is not currently possible to recover from a buffer unaligned error as this error is a fatalError so trying aligned and then falling back to unaligned is not an option. Also, FlatBuffers has a verifier that should be able to catch this error but currently it seems to fail on both aligned and unaligned buffers (I tried verifying the example python server get return value but verification fails even though the buffers are able to be read successfully) * Closes: apache#37884 Authored-by: Alva Bandy <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR enables the swift readers to read from unaligned buffers (fix for issue: 37884)
Enabling unaligned buffers incurs a performance penalty so the developer will need to consider this when enabling this feature.
It is not currently possible to recover from a buffer unaligned error as this error is a fatalError so trying aligned and then falling back to unaligned is not an option. Also, FlatBuffers has a verifier that should be able to catch this error but currently it seems to fail on both aligned and unaligned buffers (I tried verifying the example python server get return value but verification fails even though the buffers are able to be read successfully)