Skip to content

Commit

Permalink
GH-45209: [C++][CMake] Fix the issue that allocator not disabled for …
Browse files Browse the repository at this point in the history
…sanitizer cmake presets (#45210)

### Rationale for this change

I gave the reason in #45209

### What changes are included in this PR?

Adjust the inheritance list order and make a lot of simplification/regrouping/reordering for existing presets the way I see fit.

Also introduce a soft rule to order inheritance list: `sanitizer` comes before `features` comes before `base`. Though we can't really mandate such a rule (thus it's "soft") or make it clear in comments (our current cmake dosn't support comment in json), we hope people will notice this pattern and follow it when editing this file.

### Are these changes tested?

Manually tested.

### Are there any user-facing changes?

None.

* GitHub Issue: #45209

Lead-authored-by: Rossi Sun <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Rossi Sun <[email protected]>
  • Loading branch information
zanmato1984 and kou authored Jan 10, 2025
1 parent b740382 commit d0b11bb
Showing 1 changed file with 166 additions and 181 deletions.
Loading

0 comments on commit d0b11bb

Please sign in to comment.