Skip to content

Commit

Permalink
MINOR: [C++] Add missing header for ORC adapter (#44876)
Browse files Browse the repository at this point in the history
### Rationale for this change

Very minor. This source file cannot be compiled on its own manually, due to missing stringstream headers. This fixes that. Otherwise we get `implicit instantiation of undefined template` errors.

Context is we build Apache Arrow in a separate build system, Buck. As such, we do not (and cannot) 100% mirror the CMake build. In the past we've also had to patch header issues like: 529e08c. Thus, this change is for posterity to avoid having to custom patches on every new release.

### What changes are included in this PR?

Adds <sstream> which is used here: 
 https://github.com/apache/arrow/blob/main/cpp/src/arrow/adapters/orc/util.cc#L1226

### Are these changes tested?

N/A

### Are there any user-facing changes?

No

Authored-by: Mike Lui <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
  • Loading branch information
mikelui authored Nov 28, 2024
1 parent 8548c22 commit 857092c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions cpp/src/arrow/adapters/orc/util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include "arrow/adapters/orc/util.h"

#include <cmath>
#include <sstream>
#include <string>
#include <string_view>
#include <vector>
Expand Down

0 comments on commit 857092c

Please sign in to comment.