Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve zipkin plugin docs #11891

Merged
merged 13 commits into from
Jan 15, 2025
Merged

docs: improve zipkin plugin docs #11891

merged 13 commits into from
Jan 15, 2025
+313 −334

Conversation

Yilialinn
Copy link
Contributor

@Yilialinn Yilialinn commented Jan 6, 2025 •
edited by kayx23
Loading

Description

Improve zipkin plugin docs and add Chinese doc.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. doc Documentation things labels Jan 6, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 6, 2025
@Yilialinn Yilialinn changed the title docs: improve skywalking plugin docs docs: improve zipkin plugin docs Jan 7, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jan 7, 2025
kayx23
kayx23 reviewed Jan 7, 2025
View reviewed changes
docs/en/latest/plugins/zipkin.md Show resolved Hide resolved
docs/en/latest/plugins/zipkin.md Outdated Show resolved Hide resolved
docs/zh/latest/plugins/zipkin.md Outdated Show resolved Hide resolved
docs/zh/latest/plugins/zipkin.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/zipkin.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/zipkin.md Show resolved Hide resolved
docs/zh/latest/plugins/zipkin.md Show resolved Hide resolved
docs/zh/latest/plugins/zipkin.md Outdated Show resolved Hide resolved
kayx23
kayx23 reviewed Jan 10, 2025
View reviewed changes
Copy link
Member

@kayx23 kayx23 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix for lint errors and comment below. Others LGTM.

docs/en/latest/plugins/zipkin.md Outdated Show resolved Hide resolved
@kayx23
Copy link
Member

kayx23 commented Jan 13, 2025

Still have lint errors

@SkyeYoung SkyeYoung merged commit 5a3259a into apache:master Jan 15, 2025
7 checks passed
@Yilialinn Yilialinn deleted the patch-2 branch January 15, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkyeYoung SkyeYoung SkyeYoung approved these changes

@kayx23 kayx23 kayx23 approved these changes

@moonming moonming moonming approved these changes

Assignees
No one assigned
Labels
doc Documentation things size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yilialinn @kayx23 @moonming @SkyeYoung