Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-1604] Change default metric mode for eventTimeField #3358

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MarigWeizhi
Copy link
Contributor

Why are the changes needed?

Close #1604.

Brief change log

  • When creating a table, if the user sets table.event-time-field, write.metadata.metrics.column.xxx will be set to truncate(32) to prevent content like yyyy-MM-dd HH:mm:ss from being truncated by the default truncate(16)

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@github-actions github-actions bot added the module:ams-server Ams server module label Dec 9, 2024
@zhoujinsong
Copy link
Contributor

Thanks for the contribution!

The InternalIcebergCreator works only for internal catalogs.
We can control the property settings for tables in the internal catalog or mixed format tables, but hard to control Iceberg tables in the external catalogs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-server Ams server module
Projects
None yet
2 participants