Skip to content

Commit

Permalink
[AMORO-3352]Add mysql-connector-j dependency by maven profile (#3380)
Browse files Browse the repository at this point in the history
Add mysql-connector-j dependency by maven profile

Co-authored-by: 张文领 <[email protected]>
Co-authored-by: big face cat <[email protected]>
  • Loading branch information
3 people authored Jan 10, 2025
1 parent 6ead3dc commit 4be9821
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 14 deletions.
16 changes: 8 additions & 8 deletions amoro-ams/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,6 @@
<artifactId>derby</artifactId>
</dependency>

<dependency>
<groupId>mysql</groupId>
<artifactId>mysql-connector-java</artifactId>
<scope>provided</scope>
</dependency>

<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-dbcp2</artifactId>
Expand Down Expand Up @@ -403,6 +397,13 @@
<version>${pagehelper.version}</version>
</dependency>

<dependency>
<groupId>com.mysql</groupId>
<artifactId>mysql-connector-j</artifactId>
<version>${mysql-connector-j.version}</version>
<scope>${mysql-j-dependency-scope}</scope>
</dependency>

<dependency>
<groupId>org.apache.iceberg</groupId>
<artifactId>iceberg-data</artifactId>
Expand Down Expand Up @@ -451,8 +452,7 @@
<version>1.19.6</version>
<scope>test</scope>
</dependency>



</dependencies>

<build>
Expand Down
14 changes: 8 additions & 6 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,12 @@
<guava.version>32.1.1-jre</guava.version>
<hudi.version>0.14.1</hudi.version>
<pagehelper.version>6.1.0</pagehelper.version>
<mysql-connector-j.version>9.1.0</mysql-connector-j.version>

<rocksdb-dependency-scope>compile</rocksdb-dependency-scope>
<lucene-dependency-scope>compile</lucene-dependency-scope>
<aliyun-sdk-dependency-scope>provided</aliyun-sdk-dependency-scope>
<mysql-j-dependency-scope>provided</mysql-j-dependency-scope>
</properties>

<dependencies>
Expand Down Expand Up @@ -626,12 +628,6 @@
<version>${derby-jdbc.version}</version>
</dependency>

<dependency>
<groupId>mysql</groupId>
<artifactId>mysql-connector-java</artifactId>
<version>${mysql-jdbc.version}</version>
</dependency>

<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-dbcp2</artifactId>
Expand Down Expand Up @@ -1377,5 +1373,11 @@
<aliyun-sdk-dependency-scope>compile</aliyun-sdk-dependency-scope>
</properties>
</profile>
<profile>
<id>mysql-j</id>
<properties>
<mysql-j-dependency-scope>compile</mysql-j-dependency-scope>
</properties>
</profile>
</profiles>
</project>

0 comments on commit 4be9821

Please sign in to comment.