List providers #45535
Open
List providers #45535
+84
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dauinh
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton and
jscheffl
as code owners
bbovenzi
reviewed
Jan 14, 2025
airflow/ui/src/pages/Provider.tsx
Outdated
| import { useProviderServiceGetProviders } from "openapi/queries"; | ||
|
|
||
| const embedLinks = (text: string) => { | ||
| const regexUrl = /https?:\/\/[^\s)]+/gu; |
There was a problem hiding this comment.
Where is the regexUrl coming from ? It seems really simple compared to what we have at other places:
const urlRegex =
/http(s)?:\/\/[\w.-]+(\.?:[\w.-]+)*([/?#][\w\-._~:/?#[\]@!$&'()*+,;=.%]+)?/g;
|
Could you run |
|
I just did! Thank you for your reviews! I simplified the code by changing the URL into a link component. I couldn't figure out how to work with I couldn't reproduce the key prop error either, but I did have key prop for each table row. I hope that works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #43708
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.