-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-72: Supporting Pulling multiple XCOM values #45509
Conversation
Not too sure where to add the tests for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How/where to test: add some tests that create a RunteimTaskInstance method and call the functions on it.
This test was missed and will help apache#45509
Apply suggestions from code review cleanup and adding tests Co-Authored-By: Kaxil Naik <[email protected]>
b589847
to
e958a5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but you should take a look too :D since I added the test -- to verify that you are happy with it.
@amoghrajesh I merged this to tick off items :) -- but feel free to change anything in follow-up |
This test was missed and will help apache#45509
Co-Authored-By: Kaxil Naik <[email protected]> closes: apache#45243
This test was missed and will help apache#45509
Co-Authored-By: Kaxil Naik <[email protected]> closes: apache#45243
This test was missed and will help apache#45509
Co-Authored-By: Kaxil Naik <[email protected]> closes: apache#45243
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kaxil.
Yes it looks good.
Co-Authored-By: Kaxil Naik <[email protected]> closes: apache#45243
closes: #45243
We can just handle xcoms for multiple task ids in the client directly by reusing the same task runner machinery.
DAG:
Task1:
Task2:
Task3: (gets xcoms pushed by 1 and 2)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.