Use new LeaseRecoverable interface added in HADOOP-18671 #5241
Conversation
This change uses FileSystem.hasPathCapability to determine if the FileSystem implementation has the ability to recover leases. Closes apache#3494
|
https://issues.apache.org/jira/browse/HADOOP-18671 was backported to Hadoop version 3.2.5. If we want to include this change, then we will need to bump the minimum supported version. |
There was a problem hiding this comment.
https://issues.apache.org/jira/browse/HADOOP-18671 was backported to Hadoop version 3.2.5. If we want to include this change, then we will need to bump the minimum supported version.
One of the github action builds failed with the following, assuming is this failure related to this comment?
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project accumulo-server-base: Compilation failure: Compilation failure:
[ERROR] /home/runner/work/accumulo/accumulo/server/base/src/main/java/org/apache/accumulo/server/manager/recovery/HadoopLogCloser.java:[28,28] cannot find symbol
[ERROR] symbol: class CommonPathCapabilities
[ERROR] location: package org.apache.hadoop.fs
[ERROR] /home/runner/work/accumulo/accumulo/server/base/src/main/java/org/apache/accumulo/server/manager/recovery/HadoopLogCloser.java:[30,28] cannot find symbol
[ERROR] symbol: class LeaseRecoverable
[ERROR] location: package org.apache.hadoop.fs
[ERROR] -> [Help 1]
| @@ -67,8 +67,6 @@ public long close(AccumuloConfiguration conf, Configuration hadoopConf, VolumeMa | |||
| ns.append(source).close(); | |||
| log.info("Recovered lease on {} using append", source); | |||
| } | |||
| } else if (ns instanceof LocalFileSystem || ns instanceof RawLocalFileSystem) { | |||
There was a problem hiding this comment.
Do you happen to know if the local filessystem impls will have the CommonPathCapabilities.LEASE_RECOVERABLE capability?
There was a problem hiding this comment.
It looks like only DistributedFileSystem and ViewDistributedFileSystem implement the LeaseRecoverable interface.
Yes, exactly. The GH action builds with Hadoop 3.0.3, so if we want to merge this, then we need to bump the minimum supported version. |
This change uses FileSystem.hasPathCapability to determine if the FileSystem implementation has the ability to recover leases.
Closes #3494