Checks for corruption earlier and always report errors #5227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was looking into an issue were a mutation was corrupted on the network.
This caused the mutation to be written to the write ahead log and then a
failure occurred in the tablet server which left the tablet in an
inconsistent state. Modifed the tablet server code to deserialize
mutations as early as possible (it used to deserialize after writing to
the walog, now it does it before).
Wrote an IT to recreate this problem and found another bug. Writing
data to Accumulo does the following.
1. Make a startUpdate RPC to create an update session
2. Make one or more applyUpdates RPCs to add data to the session. These
RPCs are thrift oneway calls, so nothing is reported back.
3. Call closeUpdate on the session to see what happened with all of the
applyUpdates RPCs done in step 2.
If an unexpected exception happened in step 2 above then it would not be
reported back to the client. These changes fix and test that as part of
testing the corrupt mutation. After these changes if there was an error
in step 2, then step 3 now throws an exception.
|
@keith-turner - the milestone and target branch don't match on this PR |
Good catch,maybe that is why the build was failing. I swtiched the branch. |
|
Being on the wrong branch was causing the fast build to fail. I tried rerunning the build and it kept using the old branch even though I switched. I pushed a new commit and that caused the build to switch to the 2.1 branch and get further. |
dlmarion
reviewed
Jan 7, 2025
dlmarion
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was looking into an issue were a mutation was corrupted on the network. This caused the mutation to be written to the write ahead log and then a failure occurred in the tablet server which left the tablet in an inconsistent state. Modifed the tablet server code to deserialize mutations as early as possible (it used to deserialize after writing to the walog, now it does it before).
Wrote an IT to recreate this problem and found another bug. Writing data to Accumulo does the following.
If an unexpected exception happened in step 2 above then it would not be reported back to the client. These changes fix and test that as part of testing the corrupt mutation. After these changes if there was an error in step 2, then step 3 now throws an exception.