Backport FateInterleavingIT to 3.1 #5223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinrr888
reviewed
Jan 3, 2025
There was a problem hiding this comment.
Briefly looked through this and it looks good. Should maybe wait to merge this until we figure out what to do with #5214. I would also like to do a more thorough review later
Comment on lines
+147
to
+152
| store.reserve(txid); | ||
| try { | ||
| status = store.getStatus(txid); | ||
| } finally { | ||
| store.unreserve(txid, Duration.ZERO); | ||
| } |
There was a problem hiding this comment.
is reserving required in order to get the status in 3.x?
There was a problem hiding this comment.
Yes.
accumulo/core/src/main/java/org/apache/accumulo/core/fate/ZooStore.java
Lines 403 to 407 in d0fb7f5
Comment on lines
+217
to
+218
| assertEquals(2, subset.keySet().stream() | ||
| .filter(k -> k.getColumnFamily().toString().equals("TXID:" + txid)).count()); |
There was a problem hiding this comment.
For this and similar assertions, could also ensure that the isReady call occurs before the call call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.