Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add balancer meter fixes #4470 #4471

Closed
wants to merge 8 commits into from
Prev Previous commit
Next Next commit
merge latest 2.1 changes
Ed Coleman committed May 3, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit a59090ee66277c1011ca0ce98904f5c4b96091eb
Original file line number Diff line number Diff line change
@@ -100,9 +100,12 @@ public void confirmMetricsPublished() throws Exception {
cluster.stop();

Set<String> unexpectedMetrics = Set.of(METRICS_SCAN_YIELDS, METRICS_UPDATE_ERRORS,
METRICS_REPLICATION_QUEUE, METRICS_COMPACTOR_MAJC_STUCK, METRICS_SCAN_BUSY_TIMEOUT);
METRICS_REPLICATION_QUEUE, METRICS_COMPACTOR_MAJC_STUCK, METRICS_SCAN_BUSY_TIMEOUT_COUNTER);
// add sserver as flaky until scan server included in mini tests.
Set<String> flakyMetrics = Set.of(METRICS_GC_WAL_ERRORS, METRICS_FATE_TYPE_IN_PROGRESS,
METRICS_MANAGER_BALANCER_NEED_MIGRATION, METRICS_MANAGER_BALANCER_MIGRATING);
METRICS_SCAN_BUSY_TIMEOUT_COUNTER, METRICS_SCAN_RESERVATION_TIMER,
METRICS_SCAN_TABLET_METADATA_CACHE, METRICS_MANAGER_BALANCER_NEED_MIGRATION,
METRICS_MANAGER_BALANCER_MIGRATING);

Map<String,String> expectedMetricNames = this.getMetricFields();
flakyMetrics.forEach(expectedMetricNames::remove); // might not see these
You are viewing a condensed version of this merge commit. You can view the full changes here.