Allow a status of Successful when popping FATE repos #4302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When FATE cleans up transactions that are successful, it will check the auto_clean flag and if set will delete the transaction. But if it is false or not set then it will iterate over all the repos and call pop to remove them to save space so we need to add SUCCESSFUL to the allowed statuses for pop, along with FAILED_IN_PROGRESS. This closes apache#4300
|
I've run a few ITs with this and no longer see the exception pop up in the Manager log |
cshannon
changed the title
DomGarguilo
approved these changes
Feb 23, 2024
keith-turner
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When FATE cleans up transactions that are successful, it will check the
auto_cleanflag and if set will delete the transaction. But if it is false or not set then it will iterate over all the repos and call pop to remove them to save space so we need to addSUCCESSFULto the allowed statuses for pop, along withFAILED_IN_PROGRESS.We don't need to add
FAILEDbecause whenFAILED_IN_PROGRESSis set FATE will already pop all the repos and clean up before setting the status toFAILEDso pop should never be called in aFAILEDstate.This closes #4300