moves finding split points into FATE #4178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Moves finding split points from tablet from a custom thread pool in
the manager into FATE. This is done by the new Repo named FindSplits.
2. Stops tracking what splits are running in manager memory and moves
this into FATE. This is not implemented yet, plan to do that in
another PR
3. Stops tracking what tablets are unsplittable in manager memory. This
should be tracked in metadata table per apache#4177. This change can be
in its own commit. In this commit the in memory tracking is simply
removed.
These changes will reduce manager memory usage. These changes also will
make splitting tablets work much better if FATE is distributed for two
reasons. First it allows the computation to spread over multiple
manager processes. Second it allows tracking of what is splitting to
move from memory to persisted storage and not rely on a map in a single
process.
This is a WIP commit because it requires FATE changes. The needed FATE
changes were stubbed out in this PR and implemented with a in memory set
that would need to be persisted.
keith-turner
changed the title
cshannon
approved these changes
Feb 18, 2024
dlmarion
reviewed
Feb 20, 2024
server/manager/src/main/java/org/apache/accumulo/manager/split/Splitter.java
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/split/FindSplits.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will reduce manager memory usage. These changes also will make splitting tablets work much better if FATE is distributed for two reasons. First it allows the computation to spread over multiple manager processes. Second it allows tracking of what is splitting to move from memory to persisted storage and not rely on a map in a single process.
This is a WIP commit because it requires FATE changes. The needed FATE changes were stubbed out in this PR and implemented with a in memory set that would need to be persisted.