Prevent static access to non-static class member

Signed-off-by: Krzysztof Bieganski <[email protected]>
antmicro · Oct 25, 2023 · 1736a02 · 1736a02
1 parent e36fee8
commit 1736a02
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/src/V3LinkDot.cpp b/src/V3LinkDot.cpp
@@ -2740,9 +2740,8 @@ class LinkDotResolveVisitor final : public VNVisitor {
                         }
                     } else {
                         if (staticAccess && !varp->lifetime().isStatic() && !varp->isParam()) {
-                            // TODO bug4077
-                            // nodep->v3error("Static access to non-static member variable "
-                            //                << varp->prettyNameQ() << endl);
+                            nodep->v3error("Static access to non-static member variable "
+                                           << varp->prettyNameQ() << endl);
                         }
                         AstVarRef* const refp = new AstVarRef{
                             nodep->fileline(), varp, VAccess::READ};  // lvalue'ness computed later
@@ -3187,10 +3186,9 @@ class LinkDotResolveVisitor final : public VNVisitor {
             AstNodeFTask* const taskp
                 = foundp ? VN_CAST(foundp->nodep(), NodeFTask) : nullptr;  // Maybe nullptr
             if (taskp) {
-                if (staticAccess && !taskp->isStatic()) {
-                    // TODO bug4077
-                    // nodep->v3error("Static access to non-static task/function "
-                    //                << taskp->prettyNameQ() << endl);
+                if (staticAccess && taskp->classMethod() && !taskp->isStatic()) {
+                    nodep->v3error("Static access to non-static task/function "
+                                   << taskp->prettyNameQ() << endl);
                 }
                 nodep->taskp(taskp);
                 nodep->classOrPackagep(foundp->classOrPackagep());

diff --git a/test_regress/t/t_class_member_bad3.pl b/test_regress/t/t_class_member_bad3.pl
@@ -11,8 +11,8 @@
 scenarios(linter => 1);
 
 lint(
-    # fails => 1,  # TODO bug4077
-    # expect_filename => $Self->{golden_filename},
+    fails => 1,
+    expect_filename => $Self->{golden_filename},
     );
 
 ok(1);