[Enabler][692] Add a command that checks the changelog into ac and create a GitHub action #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandofloresg
requested changes
Apr 10, 2024
richp405
approved these changes
Apr 29, 2024
fernandofloresg
added
the
Do not Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes the first two bullet points of #692.
Add new command ac-check-changelog into ac tool to ensure if a new changelog fragment was added to the branch
Added new github action that will execute the check changelog check upon a new pull request with base branch dev or any branch that starts with staging. By default, it will run on three triggers:
You can see this Github Action in the following PR fernandofloresg#24
And look at the run details here https://github.com/fernandofloresg/ibm_zos_core/actions/runs/8574374819/job/23501055062?pr=24
It averages 12s of execution time.
And looking at billable details we get 0s,
ISSUE TYPE
COMPONENT NAME
ac
ADDITIONAL INFORMATION