Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iam_managed_policy - fix ParamValidationError during policy deletion #2068

Merged
merged 1 commit into from
Apr 30, 2024
Merged

iam_managed_policy - fix ParamValidationError during policy deletion #2068

merged 1 commit into from
Apr 30, 2024

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Apr 30, 2024

SUMMARY

fixes: #2067
Introduced by #1998

A copy and paste mistake in #1998 resulted in ParamValidationErrors being triggered when deleting a managed policy which is still attached to a role or user.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

iam_managed_policy
plugins/module_utils/iam.py

ADDITIONAL INFORMATION

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3825bafa16f34d38aefc27c00e96c919

✔️ ansible-galaxy-importer SUCCESS in 6m 45s
✔️ build-ansible-collection SUCCESS in 15m 00s
✔️ ansible-test-splitter SUCCESS in 6m 03s
✔️ integration-amazon.aws-1 SUCCESS in 13m 27s
✔️ integration-amazon.aws-2 SUCCESS in 7m 50s
✔️ integration-amazon.aws-3 SUCCESS in 10m 10s
✔️ integration-amazon.aws-4 SUCCESS in 6m 54s
✔️ integration-community.aws-1 SUCCESS in 26m 18s
✔️ integration-community.aws-2 SUCCESS in 7m 09s
✔️ integration-community.aws-3 SUCCESS in 7m 13s
Skipped 37 jobs

@tremble tremble requested a review from alinabuzachis April 30, 2024 09:37
@tremble tremble marked this pull request as ready for review April 30, 2024 09:37
@tremble tremble requested a review from abikouo April 30, 2024 09:37
@tremble tremble added the backport-7 PR should be backported to the stable-7 branch label Apr 30, 2024
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Apr 30, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/49cd45ef52f64718a08f32f07fa96ae7

❌ ansible-galaxy-importer RETRY_LIMIT in 7m 06s
✔️ build-ansible-collection SUCCESS in 16m 35s
✔️ ansible-test-splitter SUCCESS in 7m 29s
✔️ integration-amazon.aws-1 SUCCESS in 12m 52s
✔️ integration-amazon.aws-2 SUCCESS in 6m 36s
✔️ integration-amazon.aws-3 SUCCESS in 9m 56s
✔️ integration-amazon.aws-4 SUCCESS in 6m 53s
✔️ integration-community.aws-1 SUCCESS in 24m 58s
✔️ integration-community.aws-2 SUCCESS in 7m 22s
✔️ integration-community.aws-3 SUCCESS in 18m 23s
Skipped 37 jobs

@tremble tremble added mergeit Merge the PR (SoftwareFactory) and removed mergeit Merge the PR (SoftwareFactory) labels Apr 30, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/d1154d70a817433087c1414325c7db39

✔️ ansible-galaxy-importer SUCCESS in 5m 18s
✔️ build-ansible-collection SUCCESS in 15m 56s
✔️ ansible-test-splitter SUCCESS in 5m 40s
✔️ integration-amazon.aws-1 SUCCESS in 13m 10s
✔️ integration-amazon.aws-2 SUCCESS in 7m 41s
✔️ integration-amazon.aws-3 SUCCESS in 16m 43s
✔️ integration-amazon.aws-4 SUCCESS in 6m 33s
✔️ integration-community.aws-1 SUCCESS in 26m 10s
✔️ integration-community.aws-2 SUCCESS in 7m 02s
✔️ integration-community.aws-3 SUCCESS in 6m 58s
Skipped 37 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 970c303 into ansible-collections:main Apr 30, 2024
38 of 41 checks passed
@patchback Patchback
Copy link

patchback bot commented Apr 30, 2024 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/970c30329167632e94ecce321cec5a9112757075/pr-2068

Backported as #2071

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 30, 2024
@tremble @patchback
iam_managed_policy - fix copy and paste mistake which results in Para…
97dbccc 
…mValidationError during policy deletion (#2068)

iam_managed_policy - fix ParamValidationError during policy deletion

SUMMARY
fixes: #2067
Introduced by #1998
A copy and paste mistake in #1998 resulted in ParamValidationErrors being triggered when deleting a managed policy which is still attached to a role or user.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
iam_managed_policy
plugins/module_utils/iam.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
(cherry picked from commit 970c303)
@patchback patchback bot mentioned this pull request Apr 30, 2024
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 30, 2024
@patchback
iam_managed_policy - fix copy and paste mistake which results in Para…
2db7202 
…mValidationError during policy deletion (#2068) (#2071)

[PR #2068/970c3032 backport][stable-7] iam_managed_policy - fix ParamValidationError during policy deletion

This is a backport of PR #2068 as merged into main (970c303).
SUMMARY
fixes: #2067
Introduced by #1998
A copy and paste mistake in #1998 resulted in ParamValidationErrors being triggered when deleting a managed policy which is still attached to a role or user.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
iam_managed_policy
plugins/module_utils/iam.py
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
abraverm pushed a commit to abraverm/amazon.aws that referenced this pull request May 2, 2024
@tremble @abraverm
iam_managed_policy - fix copy and paste mistake which results in Para…
d358717 
…mValidationError during policy deletion (ansible-collections#2068)

iam_managed_policy - fix ParamValidationError during policy deletion

SUMMARY
fixes: ansible-collections#2067
Introduced by ansible-collections#1998
A copy and paste mistake in ansible-collections#1998 resulted in ParamValidationErrors being triggered when deleting a managed policy which is still attached to a role or user.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
iam_managed_policy
plugins/module_utils/iam.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
@tremble tremble deleted the issue/2067 branch June 12, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@abikouo abikouo Awaiting requested review from abikouo

Assignees
No one assigned
Labels
backport-7 PR should be backported to the stable-7 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iam_managed_policy - Unknown parameter in input: "RoleName", must be one of: GroupName, PolicyArn
2 participants
@tremble @alinabuzachis