Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fxslack): Provided module #8

Merged
merged 16 commits into from
Mar 28, 2024
Merged

feat(fxslack): Provided module #8

merged 16 commits into from
Mar 28, 2024

Conversation

Babacooll
Copy link
Contributor

No description provided.

@Babacooll Babacooll closed this Mar 26, 2024
@Babacooll Babacooll reopened this Mar 26, 2024
@Babacooll Babacooll marked this pull request as draft March 26, 2024 08:53
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6f636b5) to head (5f796bb).

Additional details and impacted files
@@             Coverage Diff             @@
##             main        #8      +/-   ##
===========================================
+ Coverage   90.10%   100.00%   +9.89%     
===========================================
  Files           3         1       -2     
  Lines          91        40      -51     
===========================================
- Hits           82        40      -42     
+ Misses          6         0       -6     
+ Partials        3         0       -3     
Flag Coverage Δ
fxgcppubsub ?
fxslack 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Babacooll Babacooll marked this pull request as ready for review March 26, 2024 10:36
Copy link
Contributor

@ekkinox ekkinox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work !

tbd:

  • some comments to check
  • missing linter config
  • tests are failing

fxslack/README.md Outdated Show resolved Hide resolved
fxslack/README.md Outdated Show resolved Hide resolved
fxslack/README.md Show resolved Hide resolved
fxslack/module.go Outdated Show resolved Hide resolved
fxslack/module_test.go Outdated Show resolved Hide resolved
@ekkinox ekkinox changed the title feat(fxslack): Add slack module feat(fxslack): Provided module Mar 26, 2024
@ekkinox ekkinox self-assigned this Mar 26, 2024
@ekkinox ekkinox merged commit 2bc872b into main Mar 28, 2024
6 checks passed
@ekkinox ekkinox deleted the feat/add-slack-module branch March 28, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants