-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MiscDrivers): Replace 2.4" TFT fonts with Liberation fonts #792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could consolidate these fonts into Libraries/MiscDrivers/Display
so we don't have to maintain multiple copies. I will take that action and move them
@vicloginov @lorne-maxim take a look at the latest changes, especially in I consolidated the fonts via a # project.mk
FONTS = LiberationSans16x16 LiberationSans28x28
# ... I also added a more generalized --- static int font = (int)&font_char_table[0];
+++ static int font = (int)&Liberation_Sans16x16[0]; |
Compilation of MAX78000 RISC-V examples fails if MAXIM_PATH is unset. It happens due to missing in Makefile.ARM ifeq "$(MAXIM_PATH)" "" |
Thanks @vicloginov, saw this for some other moved projects. Fixed most projects as of #799, but will update the RISC-V projects in this PR. The legacy split makefiles need a manual update |
I still see reference to Liberation_Sans16x16 font in many CNN examples and TFT_Demo like this: #ifdef BOARD_FTHR_REVA It causes compilation error for BOARD=FTHR_RevA |
@vicloginov fixed in 69990ee |
@vicloginov which examples?
|
Manually running auto builder, not sure why it's not triggering for this PR. https://github.com/Analog-Devices-MSDK/msdk/actions/runs/6898675901 |
Old fonts for 2.4" TFT are replaced with Liberation fonts in MAX78000/MAX78002 examples.