perf(PeriphDrivers): Remove Redundant if Statement in I2C Rev A
#781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake-Carter
requested review from
Jacob-Scheiffler,
lorne-maxim and
sihyung-maxim
| @@ -1440,11 +1440,7 @@ void MXC_I2C_RevA_MasterAsyncHandler(int i2cNum) | |||
| } | |||
|
|
|||
| /* Call the callback */ | |||
| if (i2c->intfl0 & MXC_I2C_REVA_ERROR) { | |||
There was a problem hiding this comment.
Why would we want to always pass E_COMM_ERR? I'm confused
There was a problem hiding this comment.
Whoops, cut the wrong line. e492743
sihyung-maxim
approved these changes
Oct 31, 2023
|
Merge from main, should fix the Verify Register/SVD workflow. |
Jacob-Scheiffler
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #753
Checklist Before Requesting Review