Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(BLE,Build): Fix default PAL_NVM_SIZE, add compiler checks for NVM erase functions #776

Merged
merged 5 commits into from
Oct 24, 2023
Merged

fix(BLE,Build): Fix default PAL_NVM_SIZE, add compiler checks for NVM erase functions #776

merged 5 commits into from
Oct 24, 2023

Conversation

EdwinFairchild
Copy link
Contributor

Description

Deeper look into this, the original fix in #726 was for PalFlashEraseSector since this is called by WsfNvmEraseDataAll and was caught at some point. However nothing calls PalFlashEraseChip , nonetheless PAL_NVM_SIZE should be a multiple of MXC_FLASH_PAGE_SIZE
Fixes #771

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@github-actions github-actions bot added the BLE Related to Bluetooth label Oct 23, 2023
@EdwinFairchild EdwinFairchild merged commit 7b3ad24 into main Oct 24, 2023
8 checks passed
@EdwinFairchild EdwinFairchild deleted the fix-PalFlashEraseChip branch October 24, 2023 14:26
EricB-ADI pushed a commit that referenced this pull request Nov 21, 2023
@EdwinFairchild @EricB-ADI
fix(BLE,Build): Fix default PAL_NVM_SIZE, add compiler checks for NVM…
af7866a 
… erase functions (#776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricB-ADI EricB-ADI EricB-ADI approved these changes

@yc-adi yc-adi yc-adi approved these changes

@Jake-Carter Jake-Carter Awaiting requested review from Jake-Carter

Assignees
No one assigned
Labels
BLE Related to Bluetooth
Projects
None yet
Milestone
No milestone
3 participants
@EdwinFairchild @yc-adi @EricB-ADI