-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PeriphDrivers): Implement low power modes for MAX32657 #1317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only semantics.
Thanks for the feedback. Could you be more specific? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry! Guess I didn't submit my comments with the review. Here is what I meant.
/** | ||
* @brief Enable retention regulator | ||
*/ | ||
void MXC_LP_RetentionRegEnable(void); | ||
|
||
/** | ||
* @brief Disable retention regulator | ||
*/ | ||
void MXC_LP_RetentionRegDisable(void); | ||
|
||
/** | ||
* @brief Is the retention regulator enabled | ||
* | ||
* @return 1 = enabled 0 = disabled | ||
*/ | ||
int MXC_LP_RetentionRegIsEnabled(void); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put action verb at the beginning of the function name for tone to be consistent in the rest of the file.
/**
* @brief Enable retention regulator
*/
void MXC_LP_EnableRetentionReg(void);
/**
* @brief Disable retention regulator
*/
void MXC_LP_DisableRetentionReg(void);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MXC_LP_RetentionRegIsEnabled
is fine. Didn't mean to include that function in the review window.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, one last thing. Forgot that we need to update the copyrights for this new calendar year on all files we edit.
Copyright (C) 2024-2025 Analog Devices, Inc.
Added standby mode and SRAM retention. Unavailable features are removed. Signed-off-by: Tahsin Mutlugun <[email protected]>
Update wrap_max32_lp.h to accomodate the low power modes of MAX32657. Signed-off-by: Tahsin Mutlugun <[email protected]>
Signed-off-by: Tahsin Mutlugun <[email protected]>
Thanks for the reminder. |
Found a minor issue. Adding WIP label. |
Fix GCR.PM register bit setting WUT as a wakeup source. Signed-off-by: Tahsin Mutlugun <[email protected]>
RTC, WUTs, Timers and system can use a different input for 32KHz clock based on a setting in MCR.CTRL register. Add a function to select the input for 32KHz clock. Signed-off-by: Tahsin Mutlugun <[email protected]>
32K clock is shared by RTC, WUTs, timers and system so it is better be handled by the system driver. Signed-off-by: Tahsin Mutlugun <[email protected]>
Description
This PR updates MAX32657 low power API as listed below.