Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Other): Add MAX78000 to Zephyr folder #1313

Merged
merged 3 commits into from
Jan 13, 2025
Merged

feat(Other): Add MAX78000 to Zephyr folder #1313

merged 3 commits into from
Jan 13, 2025

Conversation

yasinustunerg
Copy link
Contributor

Add MAX78000 SoC into the zephyr build system

Signed-off-by: Yasin Ustuner [email protected]

Description

  • Add MAX78000 into the zephyr build system
  • Add I2C related clock speed definitions

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@github-actions github-actions bot added MAX78000 Related to the MAX78000 (AI85) Zephyr MSDK Zephyr related change. labels Dec 23, 2024
@yasinustunerg yasinustunerg changed the title feat(zephyr): Add MAX78000 to Zephyr folder feat(Other): Add MAX78000 to Zephyr folder Dec 23, 2024
@yasinustunerg yasinustunerg force-pushed the feature/add-max78000-zephyr-support branch from 531392b to c28cd8e Compare January 6, 2025 12:18
@sihyung-maxim
Copy link
Contributor

/clang-format-run

@hfakkiz hfakkiz requested review from ttmut and sihyung-maxim January 7, 2025 08:02
sihyung-maxim
sihyung-maxim reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@sihyung-maxim sihyung-maxim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw the MAX32680 in these files. The ME20 (MAX32680) is not supported by the company anymore. It's been neglected from the MSDK since its announcement sometime last year. It might be a good idea to remove MAX32680 references.

@sihyung-maxim
Copy link
Contributor

Just saw the MAX32680 in these files. The ME20 (MAX32680) is not supported by the company anymore. It's been neglected from the MSDK since its announcement sometime last year. It might be a good idea to remove MAX32680 references.

Thoughts? @hfakkiz @ttmut @ozersa

@ttmut
Copy link
Contributor

ttmut commented Jan 9, 2025

Just saw the MAX32680 in these files. The ME20 (MAX32680) is not supported by the company anymore. It's been neglected from the MSDK since its announcement sometime last year. It might be a good idea to remove MAX32680 references.

Thoughts? @hfakkiz @ttmut @ozersa

I had not heard about that. We already upstreamed it to Zephyr so it will have to be deprecated as well if we are to proceed with removing MAX32680 support.

@yasinustunerg
Copy link
Contributor Author

Hi @sihyung-maxim, I am waiting for this PR to release zephyr. Could you review it?

@ozersa
Copy link
Contributor

ozersa commented Jan 10, 2025

Just saw the MAX32680 in these files. The ME20 (MAX32680) is not supported by the company anymore. It's been neglected from the MSDK since its announcement sometime last year. It might be a good idea to remove MAX32680 references.

Thoughts? @hfakkiz @ttmut @ozersa

Can be removed, but shall be handled by a different PR/task, please send an email on this purpose to start an action.

sihyung-maxim
sihyung-maxim reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@sihyung-maxim sihyung-maxim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot this is a new calendar year. Need to update the copyrights too. Will approve and merge once the copyrights are updated.

Copyright (C) 2023-2025 Analog Devices, Inc.

@sihyung-maxim
Copy link
Contributor

Just saw the MAX32680 in these files. The ME20 (MAX32680) is not supported by the company anymore. It's been neglected from the MSDK since its announcement sometime last year. It might be a good idea to remove MAX32680 references.

Thoughts? @hfakkiz @ttmut @ozersa

Can be removed, but shall be handled by a different PR/task, please send an email on this purpose to start an action.

Sounds good. I'll talk to Lorne so we can fully deprecate from the MSDK side.

@yasinustunerg @yasin-ADI
Add MAX78000 to Zephyr folder
f0ae38e 
This commit adds MAX78000 SoC into
the zephyr build system

Signed-off-by: Yasin Ustuner <[email protected]>
@yasinustunerg @yasin-ADI
Add clock definitions for MAX78000 SoC
cd98e31 
This commit adds i2c related clock definitions
for MAX78000 SoC

Signed-off-by: Yasin Ustuner <[email protected]>
@yasinustunerg yasinustunerg force-pushed the feature/add-max78000-zephyr-support branch from e909f00 to cd98e31 Compare January 13, 2025 17:02
@yasinustunerg
Copy link
Contributor Author

Forgot this is a new calendar year. Need to update the copyrights too. Will approve and merge once the copyrights are updated.

Copyright (C) 2023-2025 Analog Devices, Inc.

Hi @sihyung-maxim , I updated the copyrights.

@sihyung-maxim
Copy link
Contributor

/clang-format-run

@sihyung-maxim sihyung-maxim merged commit ab559fc into analogdevicesinc:main Jan 13, 2025
sihyung-maxim pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Jan 13, 2025
@actions-user
Update Zephyr MSDK Hal based on MSDK PR: analogdevicesinc/msdk#1313
aa251ae
@yasinustunerg yasinustunerg mentioned this pull request Jan 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkhnclkmxm gkhnclkmxm gkhnclkmxm approved these changes

@hfakkiz hfakkiz hfakkiz approved these changes

@sihyung-maxim sihyung-maxim sihyung-maxim approved these changes

@ttmut ttmut ttmut approved these changes

Assignees
No one assigned
Labels
MAX78000 Related to the MAX78000 (AI85) Zephyr MSDK Zephyr related change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yasinustunerg @sihyung-maxim @ttmut @ozersa @hfakkiz @gkhnclkmxm