fix: use js extensions instead of ts in imports #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenbroekema
force-pushed
the
js-extensions
branch
from
bf5c115 to
c2c7dc7
Compare
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
jorenbroekema
commented
Oct 28, 2024
| @@ -3,8 +3,6 @@ | |||
| "target": "ESNext", | |||
| "module": "ESNext", | |||
| "moduleResolution": "Bundler", | |||
| // Allow importing TypeScript files using their native extension (.ts(x)). | |||
| "allowImportingTsExtensions": true, | |||
There was a problem hiding this comment.
In latest typescript this only works with emitDeclarationOnly (we could also just set that to true), but imo this flag is kinda tech debt anyways because it relies on bundler tool to resolve the import paths, and we actually want to stay bundleless.
|
This closes #1371 🥂 |
dbanksdesign
approved these changes
Nov 4, 2024
jorenbroekema
added a commit
that referenced
this pull request
Nov 7, 2024
dbanksdesign
pushed a commit
that referenced
this pull request
Nov 7, 2024
tkgroot
pushed a commit
to tkgroot/style-dictionary
that referenced
this pull request
Dec 9, 2024
tkgroot
pushed a commit
to tkgroot/style-dictionary
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
closes #1371
Description of changes:
Generally speaking TypeScript expects .js extensions for imports because the compiled output is .js. In the future TS might release a new feature allowing .ts extensions, but currently under NodeNext moduleResolution, .js is the way to go for files that actually compile to JS.
That said, in JSDocs annotated type-only imports we should use .d.ts extension because we only emit declaration files for these, so the compiled output is just .d.ts files.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.