Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: 4.0.0 #52

Merged
merged 1 commit into from
Aug 21, 2024
Merged

revert: 4.0.0 #52

merged 1 commit into from
Aug 21, 2024

Conversation

Mercy811
Copy link
Contributor

This reverts commit 4cd73b4.

It should be a minor version.

This reverts commit 4cd73b4.
@Mercy811 Mercy811 requested a review from yuhao900914 August 21, 2024 20:57
@yuhao900914
Copy link
Contributor

Does this work?
We should also delete the release tag.
But we already released the 4.0.0 in npm and it cannot be reverted there. What if in the future we want to bump to 4.0.0?

@Mercy811
Copy link
Contributor Author

@Mercy811
Copy link
Contributor Author

Mercy811 commented Aug 21, 2024

Hi @yuhao900914, I deleted the 4.0.0 tag, the next release will based on the last version 3.8.0

@yuhao900914
Copy link
Contributor

@Mercy811 Thanks. Good to know. It's much better than maven.

@Mercy811
Copy link
Contributor Author

@yuhao900914, to prevent this from happening again I'm also going to dadd a release.yml file to branch v3.x to create a publish v3.x like what we have publish 2.x in the typescript repo https://github.com/amplitude/Amplitude-TypeScript/actions/workflows/publish-v2.yml

@Mercy811 Mercy811 merged commit 2335f0d into v3.x Aug 21, 2024
1 check passed
@Mercy811 Mercy811 deleted the AMP-107257-revert-4.0.0 branch August 21, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants