-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add repeat interval on EventPipeline to prevent high frequency requests on continuing failing #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sojingle
force-pushed
the
AMP-120507-fix-high-frequency-network-request
branch
from
December 17, 2024 03:47
7985e4d
to
93dc739
Compare
sojingle
commented
Dec 17, 2024
…equests on continuing failing
sojingle
force-pushed
the
AMP-120507-fix-high-frequency-network-request
branch
from
December 17, 2024 03:53
93dc739
to
5c45060
Compare
crleona
reviewed
Dec 17, 2024
Tests/AmplitudeTests/Utilities/PersistentStorageResponseHandlerTests.swift
Outdated
Show resolved
Hide resolved
sojingle
force-pushed
the
AMP-120507-fix-high-frequency-network-request
branch
from
December 17, 2024 20:07
732e895
to
b7782b8
Compare
sojingle
force-pushed
the
AMP-120507-fix-high-frequency-network-request
branch
from
December 17, 2024 20:13
b7782b8
to
84201ff
Compare
crleona
approved these changes
Dec 17, 2024
crleona
reviewed
Dec 17, 2024
crleona
approved these changes
Dec 17, 2024
🎉 This PR is included in version 1.11.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix: prevent high-frequency requests on continuing failing by:
Checklist