fix: restore Analytics-Connector to built from source version when distributing as a swift package #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stributing as a swift package
izaaz
reviewed
Nov 12, 2024
izaaz
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reverts changes to Package.swift that opt into the new prepackaged framework based builds, meaning SPM customers will now build analytics-connector from source. The internal Xcode project will still point to the precompiled framework as it is used in Carthage builds. This should help customers with experiencing issues with #238.
Note that the version rollback for analytics-connector is intentional, the only changes we've made are related to packaging.
Checklist