fix: correct behaviors around single-target watch apps vs watch extensions to avoid crashes when targeting watchOS 8 and lower #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sions to avoid crashes when targeting watchOS 8 and lower
thedavidharris
commented
Jun 11, 2024
| @@ -13,27 +13,57 @@ | |||
| class WatchOSLifecycleMonitor: UtilityPlugin { | |||
| var wasBackgrounded: Bool = false | |||
|
|
|||
| private var watchExtension = WKApplication.shared() | |||
There was a problem hiding this comment.
This wasn't referenced anywhere
thedavidharris
commented
Jun 11, 2024
| } | ||
| } else if !isSingleTargetApplication { | ||
| switch notification.name { | ||
| case WKExtension.applicationWillEnterForegroundNotification: |
There was a problem hiding this comment.
Splitting this out is probably overkill but wanted to be extra safe around when WKApplication or WKExtension was referenced.
|
Unsure why this test is failing. |
|
@thedavidharris Thank you for the PR! I had started work on another request (#180) which solves an additional issue we had with tracking sessions and uses slightly simpler logic (as both WKApplication and WKExtension notifications have the same underlying rawValues and acted the same across the watchOS versions I tested). Closing this PR, but please let me know if you have a scenario that I missed that require the isSingleTargetApplication / watchOS 9.0 checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist