Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the enrichment plugin to enable filter event #123

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

yuhao900914
Copy link
Contributor

@yuhao900914 yuhao900914 commented Feb 22, 2024

Summary

Jira Ticket

This is to fix the enrichment plugin that cannot filter an event.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

Copy link
Collaborator

@izaaz izaaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuhao900914!

@yuhao900914 yuhao900914 linked an issue Feb 22, 2024 that may be closed by this pull request
Copy link
Contributor

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuhao900914 changes look good.

Could you please add a unit test?

Copy link
Collaborator

@Mercy811 Mercy811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Alyssa. This is really helpful.

Could you please add a unit test?

+1 on unit test

@yuhao900914
Copy link
Contributor Author

@justin-fiedler @Mercy811 Added the Unit test.

@yuhao900914 yuhao900914 merged commit 5d3aeb0 into main Feb 23, 2024
3 checks passed
@yuhao900914 yuhao900914 deleted the enrichementPlugin branch February 23, 2024 18:42
github-actions bot pushed a commit that referenced this pull request Feb 23, 2024
## [1.3.4](v1.3.3...v1.3.4) (2024-02-23)

### Bug Fixes

* fix the enrichment plugin to enable filter event ([#123](#123)) ([5d3aeb0](5d3aeb0))
Copy link

🎉 This PR is included in version 1.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Returning nil from a plugin crashes the app
5 participants