Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option --auto-flush to enable benchmarking of ion-java writer with auto-flush configured. #59

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

linlin-s
Copy link
Contributor

Issue #, if available:

N/A

Description of changes:

This PR adds an option to benchmark the ion-java binary writing with/without auto-flush enabled.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@linlin-s
Copy link
Contributor Author

The workflow builds failed since the feature of auto-flush in ion-java has not been merged.

Copy link
Contributor

@tgregg tgregg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free once to merge once the prerequisite ion-java PRs are merged.

src/com/amazon/ion/benchmark/Main.java Outdated Show resolved Hide resolved
@linlin-s
Copy link
Contributor Author

linlin-s commented Dec 6, 2023

The new change of auto-flush hasn't been released to maven central yet, which is the reason caused build failure. I rebuild ion-java-benchmark-cli with ion-java with the latest changes. The build was successful without error. In this case we will merge this PR.

@linlin-s linlin-s merged commit 36bfda9 into master Dec 6, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants