Bump govuk_sidekiq from 6.0.0 to 7.1.3 #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
force-pushed
the
dependabot/bundler/govuk_sidekiq-7.1.3
branch
from
0fd6052 to
cb46f58
Compare
dependabot
bot
force-pushed
the
dependabot/bundler/govuk_sidekiq-7.1.3
branch
from
cb46f58 to
4e6c94e
Compare
Bumps [govuk_sidekiq](https://github.com/alphagov/govuk_sidekiq) from 6.0.0 to 7.1.3. - [Changelog](https://github.com/alphagov/govuk_sidekiq/blob/main/CHANGELOG.md) - [Commits](alphagov/govuk_sidekiq@v6.0.0...v7.1.3) --- updated-dependencies: - dependency-name: govuk_sidekiq dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Updating `govuk_sidekiq` requires updates to `active_support` and `govuk_app_config`. Also needed to fix `sidekiq` to 6.5.10 as bundler was attempting to upgrade sidekiq to a beta version 7. This won't work as we use namespaces - see this thread https://gds.slack.com/archives/CAB4Q3QBW/p1681999485484039
peteglondon
force-pushed
the
dependabot/bundler/govuk_sidekiq-7.1.3
branch
from
61e890c to
d7c848d
Compare
gclssvglx
approved these changes
Nov 24, 2023
| @@ -1,6 +1,7 @@ | |||
| $LOAD_PATH << __dir__ unless $LOAD_PATH.include?(__dir__) | |||
|
|
|||
| require_relative "../env" | |||
| require "active_support" | |||
There was a problem hiding this comment.
Yeah, I discovered this too - very odd
| @@ -26,7 +26,7 @@ | |||
|
|
|||
| # Silence log output | |||
| Logging.logger.root.appenders = nil | |||
| Sidekiq.logger = nil | |||
| Sidekiq.logger.level = Logger::WARN | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps govuk_sidekiq from 6.0.0 to 7.1.3.
Changelog
Sourced from govuk_sidekiq's changelog.
Commits
ae3bf5bMerge pull request #84 from alphagov/fix-sidekiq-requirement7af93c3Release version 7.1.3a87599fChange Sidekiq requirement to ~> 6.551ee6c3Merge pull request #83 from alphagov/bump-versiona1961a0Bump and release new versiond685105Merge pull request #82 from alphagov/sidekiq-versionf379087Loosen Sidekiq version requirementa0e842aMerge pull request #80 from alphagov/dependabot/github_actions/actions/checko...081ec95Bump actions/checkout from 3 to 40daca58Merge pull request #79 from alphagov/dependabot/bundler/rubocop-govuk-eq-4.12.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)