Merge pull request #2403 from alphagov/make-test-names-consistent

Make test names consistent
alphagov · Nov 5, 2024 · 1dd208b · 1dd208b
2 parents 42fdb5a + 7f2e074
commit 1dd208b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/test/functional/editions_controller_test.rb b/test/functional/editions_controller_test.rb
@@ -32,7 +32,7 @@ class EditionsControllerTest < ActionController::TestCase
       assert_response :not_found
     end
 
-    should "return a view for the requested guide" do
+    should "return a view for the requested edition" do
       get :show, params: { id: @edition.id }
       assert_response :success
       assert_not_nil assigns(:resource)

diff --git a/test/integration/edition_edit_test.rb b/test/integration/edition_edit_test.rb
@@ -37,7 +37,7 @@ class EditionEditTest < IntegrationTest
   end
 
   context "metadata tab" do
-    context "when state is draft" do
+    context "when state is 'draft'" do
       setup do
         visit_edition_in_draft
         click_link("Metadata")
@@ -67,7 +67,7 @@ class EditionEditTest < IntegrationTest
       end
     end
 
-    context "when state state is not draft" do
+    context "when state is not 'draft'" do
       setup do
         visit_edition_in_published
         click_link("Metadata")
@@ -103,7 +103,7 @@ class EditionEditTest < IntegrationTest
         visit_edition_in_draft
       end
 
-      context "when state is publish" do
+      context "when state is 'published'" do
         setup do
           visit_edition_in_published
           click_link("Unpublish")
@@ -132,7 +132,7 @@ class EditionEditTest < IntegrationTest
         end
       end
 
-      context "when state is not publish" do
+      context "when state is not 'published'" do
         setup do
           edition = FactoryBot.create(:edition, state: "draft")
           visit edition_path(edition)