Replace title component with heading #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
use-heading
branch
from
17b240a to
9db14d8
Compare
andysellick
requested review from
mtaylorgds
and removed request for
mtaylorgds
andysellick
force-pushed
the
use-heading
branch
from
9db14d8 to
fdd4f62
Compare
- aiming to retire title component - heading component when configured correctly is visually identical
andysellick
force-pushed
the
use-heading
branch
from
fdd4f62 to
3034752
Compare
AshGDS
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Replace instances of the title component with the heading component.
Why
We're aiming to retire the title component, as it duplicates what the heading component does.
Visual changes
None. The heading component is visually identical to the title component (when configured correctly) so there should be no difference here. I've checked by deploying this branch to integration and there is no visual difference.
Trello card: https://trello.com/c/l4VyD7Nm/395-retire-page-title-component