Skip to content

Commit

Permalink
Redefine sidekiq requirement to not install beta version
Browse files Browse the repository at this point in the history
Currently, bundler will install version `7.0.0.beta1` of sidekiq as it
considers this to be less than `7`. We do not want this to happen.

In #84, we changed the
requirement from `">= 6.5.12", "< 7"` to `"~> 6.5"`. This has a side
effect of some of our applications ending up on an earlier version of
sidekiq than `6.5.12` (there was a security fix in `6.5.10`).

Therefore in #85 we
changed the requirement to be `"> 6.5.10", "< 7"`, however this once
again resulted in bundler installing `7.0.0.beta`.

Updating the requirements again to be even more explicit, so we always
install a version newer than `6.5.12` but never a version that isn't
`6.5.x`.
  • Loading branch information
brucebolt committed Nov 28, 2023
1 parent 715c5df commit c38613e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Unreleased

* Redefine sidekiq requirement so Bundler won't install 7.0.0.beta1

# 7.1.4

* Require sidekiq > 6.5.10 and < 7
Expand Down
2 changes: 1 addition & 1 deletion govuk_sidekiq.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Gem::Specification.new do |spec|
spec.add_dependency "gds-api-adapters", ">= 19.1.0"
spec.add_dependency "govuk_app_config", ">= 1.1"
spec.add_dependency "redis-namespace", "~> 1.6"
spec.add_dependency "sidekiq", "> 6.5.10", "< 7"
spec.add_dependency "sidekiq", "~> 6.5", ">= 6.5.12"

spec.add_development_dependency "climate_control", "~> 1.2"
spec.add_development_dependency "railties", "~> 7"
Expand Down

0 comments on commit c38613e

Please sign in to comment.