Fix dependency name edge-case #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ChrisBAshton
changed the title
A recent PR was auto-merged when it should not have been: alphagov/content-data-api#1996 This is because the name of the dependency was not being matched by the regex (`\w` does not support hyphenated names). It therefore looked as though _NO_ dependencies were being updated, and it seemed therefore that there were no top-level dependencies being updated that weren't on the allowlist. govuk-dependabot-merger therefore gave the green light to auto-merge. Have now tweaked the regex to catch any kind of dependency name. This did break the `multiple_dependencies_commit` spec, because each of its dependencies is wrapped in backticks (as opposed to the single-dependency commits, which had no backticks), so the names weren't matching. I've now added an inline `gsub` to remove the backticks from the names, since they're never actually part of the dependency names.
ChrisBAshton
force-pushed
the
fix-subdependency-edge-case
branch
from
5101b5e to
ee02a46
Compare
MuriloDalRi
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent PR was auto-merged when it should not have been: alphagov/content-data-api#1996
This is because the name of the dependency was not being matched by the regex (
\wdoes not support hyphenated names). It therefore looked as though NO dependencies were being updated, and it seemed therefore that there were no top-level dependencies being updated that weren't on the allowlist. govuk-dependabot-merger therefore gave the green light to auto-merge.Have now tweaked the regex to catch any kind of dependency name. This did break the
multiple_dependencies_commitspec, because each of its dependencies is wrapped in backticks (as opposed to the single-dependency commits, which had no backticks), so the names weren't matching. I've now added an inlinegsubto remove the backticks from the names, since they're never actually part of the dependency names.