Update Rails default config for 8.0 #1588
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This app is still currently using the Rails 7 default settings (even though its Rails dependency has been upgraded to version 8). The default setting for what ActionDispatch is calling "strict freshness" is being changed in Rails 8. Since Asset Manager cares about ETag and Last-Modified and since it's happily worked with the Rails 7 default behaviour, I'm explicitly adding the setting so that it continues to behave as it has been doing even after we adopt the rest of Rails 8's default settings changes.
(Except for the action_dispatch.strict_freshness setting that was overridden in the previous commit.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to do this the other day when I upgraded the Rails gems.
https://trello.com/c/JJ02il7P/1536-properly-complete-rails-8-upgrades-for-transition-asset-manager-and-signon