Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change check nonce log lvl #307

Conversation

Francois-Gomis
Copy link
Collaborator

Reason for change

Linear task

Code changes

Change log lvl

How to test

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@Francois-Gomis Francois-Gomis marked this pull request as ready for review December 17, 2024 16:23
@Francois-Gomis Francois-Gomis requested a review from a team as a code owner December 17, 2024 16:23
Copy link

⏳E2E tests are currently running.
➡️ You can follow their progression here.

@Francois-Gomis Francois-Gomis merged commit d44ca4a into develop Dec 17, 2024
9 of 10 checks passed
@Francois-Gomis Francois-Gomis deleted the feature/ecom-2294--wc-change-csrf-nonce-log-validation-lvl branch December 17, 2024 16:25
Copy link

❌ E2E tests have failed.
➡️ You can find the results here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants