Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gather cms data #297

Merged
merged 8 commits into from
Dec 6, 2024
Merged

Add gather cms data #297

merged 8 commits into from
Dec 6, 2024

Conversation

joyet-simon
Copy link
Contributor

Reason for change

Linear task

Code changes

How to test

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@joyet-simon joyet-simon requested a review from a team as a code owner November 28, 2024 14:57
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@webaaz
Copy link
Member

webaaz commented Nov 28, 2024

Looks good to me

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@joyet-simon joyet-simon requested a review from webaaz November 28, 2024 16:34
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
Francois-Gomis
Francois-Gomis requested changes Nov 28, 2024
View reviewed changes
src/includes/Helpers/SecurityHelper.php Outdated Show resolved Hide resolved
src/includes/Services/CollectCmsDataService.php Outdated Show resolved Hide resolved
src/includes/Services/CollectCmsDataService.php Outdated Show resolved Hide resolved
src/includes/WcProxy/ThemeProxy.php Outdated Show resolved Hide resolved
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
Francois-Gomis
Francois-Gomis requested changes Dec 2, 2024
View reviewed changes
src/includes/Builders/Helpers/SecurityHelperBuilder.php Show resolved Hide resolved
src/includes/Helpers/ConstantsHelper.php Outdated Show resolved Hide resolved
src/includes/Services/CollectCmsDataService.php Outdated Show resolved Hide resolved
src/includes/Services/CollectCmsDataService.php Outdated Show resolved Hide resolved
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
Benjamin-Freoua-Alma
Benjamin-Freoua-Alma requested changes Dec 2, 2024
View reviewed changes
src/includes/Services/CollectCmsDataService.php Outdated Show resolved Hide resolved
src/includes/Services/CollectCmsDataService.php Outdated Show resolved Hide resolved
src/includes/Services/CollectCmsDataService.php Outdated Show resolved Hide resolved
src/tests/Services/CollectCmsDataServiceTest.php Show resolved Hide resolved
src/tests/Services/CollectCmsDataServiceTest.php Show resolved Hide resolved
src/tests/Services/CollectCmsDataServiceTest.php Show resolved Hide resolved
src/composer.json Outdated Show resolved Hide resolved
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
Benjamin-Freoua-Alma
Benjamin-Freoua-Alma requested changes Dec 4, 2024
View reviewed changes
Copy link
Member

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we handle to send the url during the update of the module ?

src/includes/Services/CollectCmsDataService.php Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

⏳E2E tests are currently running.
➡️ You can follow their progression here.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 50%)

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

❌ E2E tests have failed.
➡️ You can find the results here.

@joyet-simon joyet-simon merged commit cb65297 into develop Dec 6, 2024
6 of 8 checks passed
@joyet-simon joyet-simon deleted the feature/ecom-2128-wc-implement-php-client-endpoints-into-woocommerce branch December 6, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Francois-Gomis Francois-Gomis Francois-Gomis approved these changes

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma Benjamin-Freoua-Alma approved these changes

@webaaz webaaz webaaz approved these changes

Assignees
No one assigned
Labels
type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joyet-simon @webaaz @Benjamin-Freoua-Alma @Francois-Gomis