fix(commons): invalid reference to properties.d.ts in dist/types/sdk/…

…reporter/utils.d.ts of allure-js-commons (#1162)
allure-framework · Oct 2, 2024 · f38b0e7 · f38b0e7
1 parent e3c5f29
commit f38b0e7
Show file tree

Hide file tree

Showing 13 changed files with 486 additions and 66 deletions.
diff --git a/.pnp.cjs b/.pnp.cjs
diff --git a/.yarn/cache/properties-npm-1.2.1-f3483bd75a-f8a4b4210a.zip b/.yarn/cache/properties-npm-1.2.1-f3483bd75a-f8a4b4210a.zip
diff --git a/packages/allure-cypress/test/utils.ts b/packages/allure-cypress/test/utils.ts
@@ -4,8 +4,8 @@ import { mkdir, readFile, readdir, rm, stat, writeFile } from "node:fs/promises"
 import { dirname, join, relative, resolve as resolvePath } from "node:path";
 import type { TestResult, TestResultContainer } from "allure-js-commons";
 import { ContentType, attachment, step } from "allure-js-commons";
-import type { AllureResults, EnvironmentInfo } from "allure-js-commons/sdk";
-import { getPosixPath, parseProperties } from "allure-js-commons/sdk/reporter";
+import type { AllureResults } from "allure-js-commons/sdk";
+import { getPosixPath, parseEnvInfo } from "allure-js-commons/sdk/reporter";
 
 type AllureCypressPaths = {
   allureCommonsModulePath: string;
@@ -184,7 +184,7 @@ export const runCypressInlineTest = async (
                 if (resultFile === "environment.properties") {
                   const content = await readFile(fullPath, "utf8");
                   await attachment(resultFile, content, ContentType.TEXT);
-                  res.envInfo = parseProperties(content) as EnvironmentInfo;
+                  res.envInfo = parseEnvInfo(content);
                   continue;
                 }
 

diff --git a/packages/allure-js-commons/package.json b/packages/allure-js-commons/package.json
@@ -58,8 +58,7 @@
     "test": "vitest run"
   },
   "dependencies": {
-    "md5": "^2.3.0",
-    "properties": "^1.2.1"
+    "md5": "^2.3.0"
   },
   "devDependencies": {
     "@babel/cli": "^7.24.6",

diff --git a/packages/allure-js-commons/src/sdk/reporter/index.ts b/packages/allure-js-commons/src/sdk/reporter/index.ts
@@ -17,3 +17,4 @@ export {
   getLanguageLabel,
   getFrameworkLabel,
 } from "./utils/labels.js";
+export { parseEnvInfo, stringifyEnvInfo } from "./utils/envInfo.js";
diff --git a/packages/allure-js-commons/src/sdk/reporter/utils.ts b/packages/allure-js-commons/src/sdk/reporter/utils.ts
@@ -4,7 +4,6 @@ import fs from "node:fs";
 import { readFile } from "node:fs/promises";
 import path from "node:path";
 import process from "node:process";
-import properties from "properties";
 import type { Label, Link, Status, StepResult, TestResult } from "../../model.js";
 import { LabelName, LinkType, StatusByPriority } from "../../model.js";
 import type { LinkConfig, LinkTemplate } from "./types.js";
@@ -166,9 +165,6 @@ export const escapeRegExp = (value: string): string => {
   return reHasRegExpChar.test(value) ? value.replace(reRegExpChar, "\\$&") : value;
 };
 
-export const parseProperties = properties.parse;
-export const stringifyProperties = (data: any): string => properties.stringify(data, { unicode: true }).toString();
-
 // TODO: may also use URL.canParse instead (requires node.js v18.17, v19.9, or higher)
 const isUrl = (potentialUrl: string) => {
   // Short-circuits the check for many short URL cases, bypassing the try-catch logic.