Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add in SendGrid Stats #157

Merged
merged 13 commits into from
Jun 25, 2024
Merged

Feature: Add in SendGrid Stats #157

merged 13 commits into from
Jun 25, 2024

Conversation

efuller
Copy link
Contributor

@efuller efuller commented Jun 25, 2024 •
edited
Loading

Summary

The main purpose of this PR was to surface SendGrid stats for newsletters.

We also:

  • refactored out fetching stats into a custom hook
  • messaging will be displayed if there are no stats available
  • a few PHPStan fixes (there is more to be done here)

Notes for reviewers

will bump version after CR

Ticket(s)

https://l.alley.dev/dc0ce1b319

@efuller efuller marked this pull request as ready for review June 25, 2024 16:40
cahdeemer
cahdeemer approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@cahdeemer cahdeemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌻

@efuller efuller merged commit 9ef2766 into develop Jun 25, 2024
6 checks passed
@efuller efuller deleted the feature/sendgrid-stats branch June 25, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahdeemer cahdeemer cahdeemer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@efuller @cahdeemer