Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-9: Upgrade WP Type Extensions package to ^3.0 #10

Merged
merged 4 commits into from
Jan 14, 2025
Merged

issue-9: Upgrade WP Type Extensions package to ^3.0 #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3ab56b
WIP: issue-9
renatonascalves Jan 14, 2025
be99644
Upgrade WP Type Extensions package to ^3.0, plus misc changes
renatonascalves Jan 14, 2025
2253aa0
Ready for review
renatonascalves Jan 14, 2025
25c7c58
Account for 2/3
renatonascalves Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/all-pr-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
# Define a matrix of PHP/WordPress versions to test against
strategy:
matrix:
php: [8.2, 8.3]
php: [8.2, 8.3, 8.4]
wordpress: ["latest"]
multisite: [false]
runs-on: ubuntu-latest
Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ This library adheres to [Semantic Versioning](https://semver.org/) and [Keep a C

Nothing yet.

## 2.0.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dlh01 is it okay to make this update to a minor version? I'm not intimately familiar with all the changes from alleyinteractive/wp-type-extensions 2.0 to 3.0.

Copy link
Member

@dlh01 dlh01 Jan 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's anything in 3.0 that would specifically affect this library, although from the perspective of the library itself, I'm not sure that I'd label the change a "patch" version. Seems more like a minor version to me.

If you wanted to be really safe about it, I think you could do ^2.1|^3.0, right?


### Changed

- Updated package `alleyinteractive/wp-type-extensions` to ^3.0.
- Removed non-existent `@phpunit` script from `composer.json`.
- CI: Added PHP 8.4 to the test matrix.

## 2.0.1

- Updated the minimum version of `wp-bulk-task` to ^1.0.
Expand Down
5 changes: 2 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"alleyinteractive/composer-wordpress-autoloader": "^1.0",
"alleyinteractive/wp-bulk-task": "^1.0",
"alleyinteractive/wp-match-blocks": "^3.0",
"alleyinteractive/wp-type-extensions": "^2.1"
"alleyinteractive/wp-type-extensions": "^2.1|^3.0"
},
"require-dev": {
"alleyinteractive/alley-coding-standards": "^2.0",
Expand Down Expand Up @@ -66,8 +66,7 @@
"phpstan": "phpstan -v --memory-limit=512M",
"test": [
"@phpcs",
"@phpstan",
"@phpunit"
"@phpstan"
],
"tidy": "[ $COMPOSER_DEV_MODE -eq 0 ] || composer normalize"
}
Expand Down
Loading