Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-9: Upgrade WP Type Extensions package to ^3.0 #10

Merged

Conversation

renatonascalves
Copy link
Contributor

@renatonascalves renatonascalves commented Jan 14, 2025

fixes #9

  • Upgraded WP Type Extensions package to version ^3.0.
  • Implemented miscellaneous changes.

@renatonascalves renatonascalves changed the title issue-9: WIP wp-type-extensions-composer-update issue-9: Upgrade WP Type Extensions package to ^3. Jan 14, 2025
@renatonascalves renatonascalves changed the title issue-9: Upgrade WP Type Extensions package to ^3. issue-9: Upgrade WP Type Extensions package to ^3 Jan 14, 2025
@renatonascalves renatonascalves changed the title issue-9: Upgrade WP Type Extensions package to ^3 issue-9: Upgrade WP Type Extensions package to ^3.0 Jan 14, 2025
@@ -6,6 +6,14 @@ This library adheres to [Semantic Versioning](https://semver.org/) and [Keep a C

Nothing yet.

## 2.0.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dlh01 is it okay to make this update to a minor version? I'm not intimately familiar with all the changes from alleyinteractive/wp-type-extensions 2.0 to 3.0.

Copy link
Member

@dlh01 dlh01 Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's anything in 3.0 that would specifically affect this library, although from the perspective of the library itself, I'm not sure that I'd label the change a "patch" version. Seems more like a minor version to me.

If you wanted to be really safe about it, I think you could do ^2.1|^3.0, right?

@renatonascalves renatonascalves marked this pull request as ready for review January 14, 2025 10:39
@renatonascalves renatonascalves self-assigned this Jan 14, 2025
@renatonascalves renatonascalves added the enhancement New feature or request label Jan 14, 2025
@renatonascalves renatonascalves merged commit faf6779 into main Jan 14, 2025
3 checks passed
@renatonascalves renatonascalves deleted the feature/issue-9/wp-type-extensions-composer-update branch January 14, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade WP Type Extensions package to ^3.0
3 participants