Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating Autocompletes with 'show_view_link' => true #694

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dlh01
Copy link
Member

@dlh01 dlh01 commented Feb 13, 2018

This field currently generates a FM_Developer_Exception:

add_action( 'fm_post', function ( $type ) {
	$fm = new \Fieldmanager_Autocomplete( 'Foo', [
		'name' => 'foo',
		'show_view_link' => true,
		'datasource' => new \Fieldmanager_Datasource_Post(),
	] );
	$fm->add_meta_box( 'Bar', $type );
} );

because show_view_link is not a property on \Fieldmanager_Autocomplete. But everything else seems to be set up for it to work (with posts and terms, anyway).

A workaround is to just set $fm->show_view_link = true after instantiating the class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant