-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Actions and PHPCS updates #108
Open
mslinnea
wants to merge
33
commits into
main
Choose a base branch
from
feature/github-actions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,275
−631
Open
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
1ed79e4
Move from Travis to Github Actions
mslinnea 59a792d
phpcs part 1
mslinnea 1451311
PHPCS
mslinnea 69a2179
move github actions files
mslinnea a69717f
Specify test matrix
mslinnea 702b729
Remove remaining references to travis
mslinnea 952db3c
ES 8.x compat - remove type from endpoint
mslinnea a6282d6
phpcs ignores
mslinnea 984ed0f
Skips tests due to WP core bug with offset & pagination
mslinnea d00d908
formatting changes
mslinnea b857984
Update composer.json
mslinnea f2a880a
Update .github/workflows/coding-standards.yml
mslinnea 572ca2e
whitespace
mslinnea a2a3cbb
Update comment block
mslinnea 2d5c664
Update comment block
mslinnea 3b244aa
formatting
mslinnea f9aa00b
formatting
mslinnea 5a517a4
mysql test matrix
mslinnea e3d228e
add mysql version to test name
mslinnea 78aff10
Update MySQL test matrix
mslinnea 5b0ebc7
formatting
mslinnea 14fb9b1
update test setup function
mslinnea 1cc297e
Update .github/workflows/coding-standards.yml
mslinnea 6cec296
Update .github/workflows/coding-standards.yml
mslinnea ca43537
Update .github/workflows/unit-tests.yml
mslinnea 3bb279e
Update .github/workflows/unit-tests.yml
mslinnea a4065b3
Update composer.json
mslinnea 4d3c5d8
Mark as knownWPBug
mslinnea f2a0d09
Revert "Update .github/workflows/unit-tests.yml"
mslinnea c7382d0
Revert "Update .github/workflows/unit-tests.yml"
mslinnea 2d6400c
Update actions and use ubuntu version with svn
mslinnea 28d4e7d
Use ubuntu latest and install svn
mslinnea 05e2834
Revert "Mark as knownWPBug"
mslinnea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
Skips tests due to WP core bug with offset & pagination
commit 984ed0f1e718b39c4f49288953a0af35a2dfafb7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ticket
is not actually a valid phpDoc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ticket
is a special annotation that the core phpunit test suite adds. If I recall correctly (and I may not, it's been a long time!), based on the status of the ticket, this test would either be run or skipped automatically. Was that feature not working on GitHub Actions, or did the test start failing after the annotation was changed to the full url? Or does core's test suite work differently now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't working to skip the tests in Github Actions or locally. I can investigate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently that feature was removed back in 2021. Womp womp.
@ticket
is still a valid annotation, but since it no longer functions in a useful way for us, I agree that@link
is better. If we want, we can still conditionally skip the test based on the status of the ticket by calling:That might be better than always skipping it? 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mboynes TIL. Thank you for the link. 〽️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you would think that would be better, but not at the moment, as it failed due to no access to trac!! Therefore, I reverted back...