Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove built branch workflow in favor of updated built release workflow #289

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

srtfisher
Copy link
Member

@srtfisher srtfisher commented Nov 30, 2023

With alleyinteractive/.github#68, the built-release.yml will replace the former built-branch.yml workflow. You can always add the workflow back to your project but for most purposes of plugin's that use this template, built-release.yml will suffice to create a built version of the main branch of the project.

Copy link

coderabbitai bot commented Nov 30, 2023

Walkthrough

The changes involve workflow adjustments in a GitHub repository. A conditional check was removed from one workflow file, allowing it to run regardless of the repository, while another workflow file was updated to include a conditional check to ensure it only runs for a specific repository. Additionally, a PHP file was updated to modify a function's parameter type and improve the clarity of comments within the code.

Changes

File Path Change Summary
.github/workflows/built-release.yml Removed conditional check to allow workflow to run on any repository.
.github/workflows/.../merge-develop-to-scaffold.yml Added conditional check to restrict workflow to the 'alleyinteractive/create-wordpress-plugin' repository.
configure.php Updated contributing_message function to accept a string parameter and return void; improved comments for clarity.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@mogmarsh mogmarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@srtfisher srtfisher merged commit 7a03631 into develop Nov 30, 2023
8 checks passed
@srtfisher srtfisher deleted the built-release-workflow branch November 30, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants