Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPLE-182: Make Aside Class Field Not Required #1128

Merged

Conversation

kevinfodness
Copy link
Member

@kevinfodness kevinfodness commented May 22, 2024

Summary

Makes the aside class field optional in settings, in case publishers don't want to use that feature, or in case they aren't ready to populate that field when adding their channel credentials during initial setup.

Changelog entries

Changed

  • Made Aside Class Field not required on the settings screen.

Tickets

Fixes #1124

@kevinfodness kevinfodness changed the title APPLE-182: Make Aside Class Field Not Required (release/v2.5.0) APPLE-182: Make Aside Class Field Not Required May 22, 2024
@kevinfodness kevinfodness marked this pull request as ready for review May 22, 2024 20:52
Copy link

@kaitlinbolling kaitlinbolling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kevinfodness kevinfodness merged commit 9ee2bce into release/v2.5.0 May 22, 2024
11 checks passed
@kevinfodness kevinfodness deleted the feature/APPLE-182/make-aside-class-field-optional branch May 22, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants