Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error when Using Gutenberg Cover Block with Caption #1122

Merged

Conversation

kevinfodness
Copy link
Member

@kevinfodness kevinfodness commented May 10, 2024

Summary

Fixes #1117

Description

Fixes a bug where attempting to convert a post containing a Cover block with a caption results in an incorrect caption format which throws an error on publish in Apple News.

Changes Made

  • Added a test for the cover block that reproduces the issue.
  • Fixed the issue by not handling captions in a special way for cover blocks.

How to Test

  1. Create a post with a Cover block. Assign the Cover block an image and a caption.
  2. Attempt to publish to Apple News.
  3. Confirm that the error previously encountered does not occur and that the article, including the cover block, is correctly formatted in Apple News.

Additional Notes

This fix aims to improve the compatibility of WordPress Gutenberg blocks with Apple News, enhancing the publishing workflow for content creators.

Related Links

@kevinfodness kevinfodness marked this pull request as ready for review May 10, 2024 19:44
@kevinfodness kevinfodness changed the title Issue-1117: Gutenberg Cover pattern causing error when publishing to Apple News (release/v2.5.0) Fix Error when Using Gutenberg Cover Block with Caption May 10, 2024
Copy link

@kaitlinbolling kaitlinbolling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖼️

@kevinfodness kevinfodness merged commit b1bed12 into release/v2.5.0 May 10, 2024
11 checks passed
@kevinfodness kevinfodness deleted the fix/issue-1117/gutenberg-cover-publish-error branch May 10, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants