Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPLE-173: Allow Default Tag Styles to be Editable via Customize JSON #1109

Conversation

kevinfodness
Copy link
Member

@kevinfodness kevinfodness commented Apr 25, 2024

Adds support for customizing default tag styles using Customize JSON and the Body component. Previously these were only available in code. Also adds styles for the <cite> tag, including theme fields for customizing these styles alongside the monospaced tag styles.

Changelog entries

Added

  • Customizable text style for the <cite> tag.

Changed

  • Make text styles customizable within the Body settings in Customize JSON.

Ticket(s)

Fixes #1075

@kevinfodness kevinfodness changed the title APPLE-173: Support and expand default tag stylings (release/v2.5.0) APPLE-173: Allow Default Tag Styles to be Editable via Customize JSON Apr 30, 2024
@kevinfodness kevinfodness marked this pull request as ready for review April 30, 2024 21:23
Copy link
Member

@dlh01 dlh01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌳

includes/apple-exporter/builders/class-text-styles.php Outdated Show resolved Hide resolved
@kevinfodness kevinfodness merged commit 38fcd1c into release/v2.5.0 May 1, 2024
8 checks passed
@kevinfodness kevinfodness deleted the feature/APPLE-173/support-expand-default-tag-stylings branch May 1, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants